[ATO 490] Rasa train doesn't throw an error if form in slot mappings active loop doesn't exist #12324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-rasa-train-doesnt-throw-an-error-if-form-in-slot-mappings-active-loop-doesnt-exist
Urkem
changed the title
Urkem
changed the title
…esnt-throw-an-error-if-form-in-slot-mappings-active-loop-doesnt-exist
Urkem
requested review from
a team and
radovanZRasa
and removed request for
a team
ancalita
reviewed
Apr 26, 2023
…esnt-throw-an-error-if-form-in-slot-mappings-active-loop-doesnt-exist
…esnt-throw-an-error-if-form-in-slot-mappings-active-loop-doesnt-exist
|
Kudos, SonarCloud Quality Gate passed!
|
ancalita
reviewed
May 2, 2023
…esnt-throw-an-error-if-form-in-slot-mappings-active-loop-doesnt-exist
m-vdb
reviewed
May 4, 2023
docs/docs/command-line-interface.mdx
Outdated
| @@ -135,6 +135,10 @@ these, `rasa train` will fall back to one of these commands by default. | |||
| The name of the model by default is `<timestamp>.tar.gz`. If you want to name your model differently, | |||
| you can specify the name using the `--fixed-model-name` flag. | |||
|
|
|||
| By default validation is run before training the model. If you want to skip validation, you can use the `--skip-validation` flag. | |||
| If you want to fail on validation warnings, you can use the `--fail-on-validation-warnings` flag. | |||
| The --validation-max-history is analogous to the `--max-history` argument of `rasa data validate`. | |||
There was a problem hiding this comment.
Suggested change
| The --validation-max-history is analogous to the `--max-history` argument of `rasa data validate`. | |
| The `--validation-max-history` is analogous to the `--max-history` argument of `rasa data validate`. |
ancalita
approved these changes
May 4, 2023
docs/docs/command-line-interface.mdx
Outdated
| @@ -135,6 +135,10 @@ these, `rasa train` will fall back to one of these commands by default. | |||
| The name of the model by default is `<timestamp>.tar.gz`. If you want to name your model differently, | |||
| you can specify the name using the `--fixed-model-name` flag. | |||
|
|
|||
| By default validation is run before training the model. If you want to skip validation, you can use the `--skip-validation` flag. | |||
| If you want to fail on validation warnings, you can use the `--fail-on-validation-warnings` flag. | |||
| The --validation-max-history is analogous to the `--max-history` argument of `rasa data validate`. | |||
|
🚀 A preview of the docs have been deployed at the following URL: https://12324--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Urkem
deleted the
ATO-490-rasa-train-doesnt-throw-an-error-if-form-in-slot-mappings-active-loop-doesnt-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
--validate-before-training,--fail-on-validation-warningsand--validation-max-historytorasa trainto bring it inline withrasa data validateStatus (please check what you already did):
black(please check Readme for instructions)