Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename core-ai-squad to engine-squad in CODEOWNERS #11802

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Rename core-ai-squad to engine-squad in CODEOWNERS #11802

merged 1 commit into from
Nov 28, 2022

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Nov 28, 2022

Proposed changes:

  • Rename core-ai-squad to engine-squad in CODEOWNERS

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@m-vdb m-vdb requested a review from tmbo November 28, 2022 09:49
@m-vdb m-vdb enabled auto-merge November 28, 2022 09:49
tmbo
tmbo approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just to double check: did you already rename the github group?

@m-vdb
Copy link
Collaborator Author

m-vdb commented Nov 28, 2022

yep :)

@m-vdb m-vdb disabled auto-merge November 28, 2022 10:02
@m-vdb m-vdb merged commit 961ed7d into main Nov 28, 2022
@m-vdb m-vdb deleted the rename-coreai-squad branch November 28, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-vdb @tmbo