fixes for failing tests

rasa/core/policies/rule_policy.py

@@ -499,11 +499,9 @@ def _collect_sources(
         # in order to correctly output the names of the contradicting rules
         rule_name = tracker.sender_id
 
-        if prediction_source is None:
-            return None
-
-        if prediction_source.startswith(DEFAULT_RULES) or prediction_source.startswith(
-            LOOP_RULES
+        if isinstance(prediction_source, str) and (
+            prediction_source.startswith(DEFAULT_RULES)
+            or prediction_source.startswith(LOOP_RULES)
         ):
             # the real gold action contradict the one in the rules in this case
             gold_action_name = predicted_action_name

rasa/core/test.py

@@ -5,7 +5,7 @@
 import warnings as pywarnings
 import typing
 from collections import defaultdict, namedtuple
-from typing import Any, Dict, List, Optional, Text, Tuple, cast
+from typing import Any, Dict, List, Optional, Text, Tuple
 
 from rasa import telemetry
 from rasa.core.constants import (
@@ -434,7 +434,8 @@ def _create_data_generator(
     from rasa.shared.core.generator import TrainingDataGenerator
 
     tmp_domain_path = Path(tempfile.mkdtemp()) / "domain.yaml"
-    cast(Domain, agent.domain).persist(tmp_domain_path)
+    domain = agent.domain if isinstance(agent.domain, Domain) else Domain.empty()
+    domain.persist(tmp_domain_path)
     test_data_importer = TrainingDataImporter.load_from_dict(
         training_data_paths=[resource_name], domain_path=str(tmp_domain_path)
     )
@@ -822,15 +823,12 @@ async def _predict_tracker_actions(
     List[EntityEvaluationResult],
 ]:
 
-    processor = cast(MessageProcessor, agent.processor)
+    processor = agent.processor
     tracker_eval_store = EvaluationStore()
 
     events = list(tracker.events)
 
-    if not isinstance(agent.domain, Domain):
-        slots = []
-    else:
-        slots = agent.domain.slots
+    slots = agent.domain.slots if isinstance(agent.domain, Domain) else []
 
     partial_tracker = DialogueStateTracker.from_events(
         tracker.sender_id,

rasa/core/training/interactive.py

@@ -955,7 +955,7 @@ async def _predict_till_next_listen(
         if result is None:
             result = {}
 
-        predictions = result.get("scores") or []
+        predictions = result.get("scores", [])
         if not predictions:
             raise InvalidConfigException(
                 "Cannot continue as no action was predicted by the dialogue manager. "
@@ -1476,10 +1476,7 @@ async def record_messages(
             )
             return
 
-        if domain is None:
-            domain_intents = []
-        else:
-            domain_intents = domain.get("intents")
+        domain_intents = domain.get("intents", []) if isinstance(domain, dict) else []
 
         intents = [next(iter(i)) for i in domain_intents]
 

rasa/validator.py

@@ -191,8 +191,10 @@ def verify_utterances_in_stories(self, ignore_warnings: bool = True) -> bool:
                 if not isinstance(event, ActionExecuted):
                     continue
 
-                action_name = event.action_name if event.action_name is not None else ""
-                if not action_name.startswith(UTTER_PREFIX):
+                if not isinstance(event.action_name, str):
+                    continue
+
+                if not event.action_name.startswith(UTTER_PREFIX):
                     # we are only interested in utter actions
                     continue
 
@@ -261,9 +263,10 @@ def verify_actions_in_stories_rules(self) -> bool:
                 if not isinstance(event, ActionExecuted):
                     continue
 
-                action_name = event.action_name if event.action_name is not None else ""
+                if not isinstance(event.action_name, str):
+                    continue
 
-                if action_name.startswith("action_"):
+                if not event.action_name.startswith("action_"):
                     continue
 
                 if event.action_name in visited: