Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(chore): Update tf-cuda config for TF 2.7 #10889

Merged
merged 11 commits into from
Feb 28, 2022
Merged

Conversation

HotThoughts
Copy link
Contributor

@HotThoughts HotThoughts commented Feb 14, 2022

Proposed changes:

According to the TF CUDA compatibility matrix, TF 2.7 still use CUDA 11.2 and cuDNN 8.1.

TODO:

  • Add a step to make sure the tf-cuda config is updated with TF upgrades.
    Example run
    image

@HotThoughts HotThoughts changed the base branch from main to 3.0.x February 14, 2022 15:14
@github-actions github-actions bot deleted a comment from HotThoughts Feb 14, 2022
@HotThoughts HotThoughts self-assigned this Feb 14, 2022
@RasaHQ RasaHQ deleted a comment from github-actions bot Feb 14, 2022
@github-actions
Copy link
Contributor

@HotThoughts
Copy link
Contributor Author

HotThoughts commented Feb 14, 2022

Please ignore all aboves ☝🏻 . I was trying to test it out by running the model regression test on GPU runner. However, the branch 3.0.x has not upgraded to TF 2.7.
😛 Only The main branch had.

@HotThoughts HotThoughts force-pushed the update-tf-cuda-config branch from c3e37f8 to 9f447d0 Compare February 21, 2022 11:15
@HotThoughts HotThoughts force-pushed the update-tf-cuda-config branch from 9f447d0 to d6caaa0 Compare February 28, 2022 09:36
@github-actions
Copy link
Contributor

@github-actions github-actions bot deleted a comment from HotThoughts Feb 28, 2022
@github-actions
Copy link
Contributor

Hey @HotThoughts! 👋 To run model regression tests, comment with the /modeltest command and a configuration.

Tips 💡: The model regression test will be run on push events. You can re-run the tests by re-add status:model-regression-tests label or use a Re-run jobs button in Github Actions workflow.

Tips 💡: Every time when you want to change a configuration you should edit the comment with the previous configuration.

You can copy this in your comment and customize:

/modeltest

```yml
##########
## Available datasets
##########
# - "Carbon Bot" (NLU)
# - "Hermit" (NLU)
# - "Private 1" (NLU)
# - "Private 2" (NLU)
# - "Private 3" (NLU)
# - "Sara" (NLU, Core)
# - "financial-demo" (NLU, Core)
# - "helpdesk-assistant" (NLU, Core)
# - "insurance-demo" (NLU, Core)
# - "retail-demo" (NLU, Core)

##########
## Available NLU configurations
##########
# - "BERT + DIET(bow) + ResponseSelector(bow)"
# - "BERT + DIET(seq) + ResponseSelector(t2t)"
# - "Spacy + DIET(bow) + ResponseSelector(bow)"
# - "Spacy + DIET(seq) + ResponseSelector(t2t)"
# - "Sparse + BERT + DIET(bow) + ResponseSelector(bow)"
# - "Sparse + BERT + DIET(seq) + ResponseSelector(t2t)"
# - "Sparse + DIET(bow) + ResponseSelector(bow)"
# - "Sparse + DIET(seq) + ResponseSelector(t2t)"
# - "Sparse + Spacy + DIET(bow) + ResponseSelector(bow)"
# - "Sparse + Spacy + DIET(seq) + ResponseSelector(t2t)"

##########
## Available Core configurations
##########
# - "Rules"
# - "Rules + AugMemo"
# - "Rules + AugMemo + TED"
# - "Rules + Memo"
# - "Rules + Memo + TED"
# - "Rules + TED"

## Example configuration
#################### syntax #################
## include:
##   - dataset: ["<dataset_name>"]
##     config: ["<configuration_name>"]
#
## Example:
## include:
##  - dataset: ["Carbon Bot"]
##    config: ["Sparse + DIET(bow) + ResponseSelector(bow)"]
#
## Shortcut:
## You can use the "all" shortcut to include all available configurations or datasets
#
## Example: Use the "Sparse + EmbeddingIntent + ResponseSelector(bow)" configuration
## for all available datasets
## include:
##  - dataset: ["all"]
##    config: ["Sparse + DIET(bow) + ResponseSelector(bow)"]
#
## Example: Use all available configurations for the "Carbon Bot" and "Sara" datasets
## and for the "Hermit" dataset use the "Sparse + DIET + ResponseSelector(T2T)" and
## "BERT + DIET + ResponseSelector(T2T)" configurations:
## include:
##  - dataset: ["Carbon Bot", "Sara"]
##    config: ["all"]
##  - dataset: ["Hermit"]
##    config: ["Sparse + DIET(seq) + ResponseSelector(t2t)", "BERT + DIET(seq) + ResponseSelector(t2t)"]
#
## Example: Define a branch name to check-out for a dataset repository. Default branch is 'main'
## dataset_branch: "test-branch"
## include:
##  - dataset: ["Carbon Bot", "Sara"]
##    config: ["all"]
##
## Shortcuts:
## You can use the "all" shortcut to include all available configurations or datasets.
## You can use the "all-nlu" shortcut to include all available NLU configurations or datasets.
## You can use the "all-core" shortcut to include all available core configurations or datasets.

include:
 - dataset: ["Carbon Bot"]
   config: ["Sparse + DIET(bow) + ResponseSelector(bow)"]

```

@github-actions
Copy link
Contributor

/modeltest

include:
 - dataset: ["Carbon Bot"]
   config: ["Sparse + DIET(bow) + ResponseSelector(bow)"]

@github-actions
Copy link
Contributor

The model regression tests have started. It might take a while, please be patient.
As soon as results are ready you'll see a new comment with the results.

Used configuration can be found in the comment.

@github-actions
Copy link
Contributor

This reverts commit 2ad744d.
@HotThoughts HotThoughts marked this pull request as ready for review February 28, 2022 13:27
@HotThoughts HotThoughts requested a review from a team as a code owner February 28, 2022 13:27
@HotThoughts HotThoughts requested review from virtualroot and removed request for a team February 28, 2022 13:27
Copy link

@tczekajlo tczekajlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HotThoughts HotThoughts enabled auto-merge (squash) February 28, 2022 14:45
@HotThoughts HotThoughts merged commit 736d06f into 3.0.x Feb 28, 2022
@HotThoughts HotThoughts deleted the update-tf-cuda-config branch February 28, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants