-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify limitations of LanguageModelFeaturizer in docs #10616
Conversation
🚀 A preview of the docs have been deployed at the following URL: https://10616--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
@koernerfelicia @dakshvar22 Hi, I just wanted to check what you think and if this would improve the LM featurizer docs, since we've had frequent questions about this on the user forum recently. Not sure if I'm missing anything on the requirements for model weights to be useable with our implementation, but those listed were the ones I experienced as causes for errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for picking this one up @mleimeister! I've added a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks grand!
This docs update aims to clarify some details around which HuggingFace models can be used with
LanguageModelFeaturizer
. Despite the supported architectures being listed in our docs, users often try others and report errors in the forum. Furthermore, not all pretrained weights from the HF models hub for the supported architectures can be used (e.g. due to missing TF weights or non-standard tokenizers being used), which results in error messages that are hard to interpret.A related ticket with links to forum issues can be found here here.
Proposed changes:
LanguageModelFeaturizer
w.r.t. model architectures and weights from HuggingFaceStatus (please check what you already did):
black
(please check Readme for instructions)