add TypeError fix and testing #10582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tmbo
reviewed
Dec 30, 2021
joejuzl
reviewed
Jan 3, 2022
tayfun
reviewed
Jan 5, 2022
joejuzl
reviewed
Jan 10, 2022
Co-authored-by: Joe Juzl <joejuzl@gmail.com>
|
No longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10567. Simply adds a default empty string when requesting an environmental var to avoid passing in a NoneType.
Added some, perhaps over-engineered, testing to catch future encoding errors.
Status (please check what you already did):
black(please check Readme for instructions)