Skip to content

fix over-indent in Tokenizers section of docs #10555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2022

Conversation

Polaris000
Copy link
Contributor

@Polaris000 Polaris000 commented Dec 19, 2021

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@koernerfelicia
Copy link
Contributor

koernerfelicia commented Jan 28, 2022

Hi @Polaris000, thanks for the change, and for your patience! Could you, please, change the changelog filename from bugfix to doc? Otherwise this looks great, and we'll make sure to get it merged ASAP! 🚀

@@ -0,0 +1 @@
Fixed an over-indent in the Tokenizers section of the Components page of the docs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be named 10553.docs.md

Copy link
Contributor Author

@Polaris000 Polaris000 Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Please have a look

Copy link
Contributor

@koernerfelicia koernerfelicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you again! 🚀

@koernerfelicia koernerfelicia merged commit fd415f1 into RasaHQ:main Jan 28, 2022
@Polaris000 Polaris000 deleted the over-indent-fix-docs branch January 28, 2022 12:29
tayfun pushed a commit that referenced this pull request Jan 28, 2022
* fix over-indent in Tokenizers section of docs
* add changelog
* rename changelog from bug to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokenizers section over-indented on the Components page
2 participants