Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix param name in CountVectorsFeaturizer #10047

Merged
merged 2 commits into from
Nov 2, 2021
Merged

fix param name in CountVectorsFeaturizer #10047

merged 2 commits into from
Nov 2, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Nov 1, 2021

Proposed changes:

  • rename spacy_nlp to model as the recipe by default tries to fill the model param if model_from was specified

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested review from joejuzl, a team and tttthomasssss and removed request for a team and tttthomasssss November 1, 2021 13:14
joejuzl
joejuzl approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@joejuzl joejuzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@wochinge wochinge enabled auto-merge (squash) November 2, 2021 12:52
@wochinge wochinge merged commit 6df732c into main Nov 2, 2021
@wochinge wochinge deleted the fix-model_from branch November 2, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joejuzl joejuzl joejuzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @joejuzl