Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markers / validation #10012

Merged
merged 14 commits into from
Nov 2, 2021
Merged

markers / validation #10012

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3404d26
validation; name vs tag; specify expected number of sub-markers;...
ka-bu Oct 29, 2021
2c31a5e
Delete old Marker test fixtures and associated files.
aeshky Oct 29, 2021
41a8ad4
Fix tests after rebasing main
usc-m Nov 1, 2021
95f4c83
First pass on domain validation
usc-m Nov 1, 2021
a98e985
Add some tests around domain validation
usc-m Nov 1, 2021
4231a41
Remove unused markers test data
usc-m Nov 1, 2021
3e3ce24
Config validation tests
usc-m Nov 1, 2021
ea3b0b3
Fix lint
usc-m Nov 1, 2021
f33b8c4
add tests for from_path; simplify other tests
ka-bu Nov 2, 2021
9a7ef5e
make domain path optional for _run_markers
ka-bu Nov 2, 2021
32e3a4f
Codeclimate fixes
usc-m Nov 2, 2021
663d651
Codeclimate fixes
usc-m Nov 2, 2021
c3d972e
Merge branch 'main' into markers/validate
usc-m Nov 2, 2021
730689a
Swap over warnings for errors
usc-m Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Swap over warnings for errors
  • Loading branch information
@usc-m
usc-m committed Nov 2, 2021
commit 730689a7e6a68b02546512fd150f608285ffac0b
12 changes: 6 additions & 6 deletions rasa/core/evaluation/marker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
MarkerRegistry,
)
from rasa.shared.core.events import ActionExecuted, SlotSet, UserUttered, Event
import rasa.shared.utils.io
import logging

logger = logging.getLogger(__name__)


@MarkerRegistry.configurable_marker
Expand Down Expand Up @@ -158,7 +160,7 @@ def validate_against_domain(self, domain: Domain) -> bool:
valid = self.text in domain.action_names_or_texts

if not valid:
rasa.shared.utils.io.raise_warning(
logger.error(
f"Referenced action '{self.text}' does not exist in the domain"
)

Expand Down Expand Up @@ -196,7 +198,7 @@ def validate_against_domain(self, domain: Domain) -> bool:
valid = self.text in domain.intent_properties

if not valid:
rasa.shared.utils.io.raise_warning(
logger.error(
f"Referenced intent '{self.text}' does not exist in the domain"
)

Expand Down Expand Up @@ -235,9 +237,7 @@ def validate_against_domain(self, domain: Domain) -> bool:
valid = any(self.text == slot.name for slot in domain.slots)

if not valid:
rasa.shared.utils.io.raise_warning(
f"Referenced slot '{self.text}' does not exist in the domain"
)
logger.error(f"Referenced slot '{self.text}' does not exist in the domain")

return valid

Expand Down