Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marker stats #10009

Merged
merged 14 commits into from
Oct 29, 2021
Merged

marker stats #10009

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3ce64d9
marker stats (flat format)
ka-bu Oct 28, 2021
707049b
ccodeclimate; dialogue->session; add macro avg
ka-bu Oct 29, 2021
475d222
Merge branch 'main' into marker/stats
ka-bu Oct 29, 2021
147edfe
codeclimate
ka-bu Oct 29, 2021
245e691
Merge branch 'marker/stats' of https://github.com/RasaHQ/rasa into ma…
ka-bu Oct 29, 2021
12ed136
minor (rm unused import; add missing param)
ka-bu Oct 29, 2021
4789e10
minor (rm breakpoint)
ka-bu Oct 29, 2021
809e2b4
small fixes (types, forgotten assert)
ka-bu Oct 29, 2021
95fe5b9
Apply suggestions from code review
ka-bu Oct 29, 2021
14f914f
wrapper -> protocol; clarify types in tests; adapt process interface
ka-bu Oct 29, 2021
a6c200e
separate writing of session and overall stats
ka-bu Oct 29, 2021
d5cf071
Merge branch 'main' into marker/stats
ka-bu Oct 29, 2021
40f8f22
typing.Protocol -> typing_extensions.Protocol
ka-bu Oct 29, 2021
e8df3d8
lint
ka-bu Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
codeclimate
  • Loading branch information
@ka-bu
ka-bu committed Oct 29, 2021
commit 147edfeecfe3a45c21d638be96968e3cc769effc
39 changes: 27 additions & 12 deletions rasa/core/evaluation/marker_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import numpy as np


from rasa.core.evaluation.marker_base import EventMetaData
from rasa.core.evaluation.marker_base import EventMetaData, Marker


def compute_statistics(
Expand Down Expand Up @@ -230,17 +230,32 @@ def _write_overall_statistics(self, table_writer: _CSVWriter) -> None:
def _write_per_session_statistics(self, table_writer: _CSVWriter) -> None:
for marker_name, collected_statistics in self.session_results.items():
for statistic_name, values in collected_statistics.items():
for record_idx, (sender_id, session_idx) in enumerate(
self.session_identifier
):
MarkerStatistics._write_row(
table_writer=table_writer,
sender_id=sender_id,
session_idx=session_idx,
marker_name=marker_name,
statistic_name=self._add_num_user_turns_str_to(statistic_name),
statistic_value=values[record_idx],
)
self._write_per_session_statistic(
table_writer=table_writer,
marker_name=marker_name,
statistic_name=statistic_name,
values=values,
)

@staticmethod
def _write_per_session_statistic(
session_identifier: List[Tuple[Text, int]],
marker_name: Text,
statistic_name: Text,
values: List[Union[np.float, int]],
table_writer: _CSVWriter,
) -> None:
for record_idx, (sender_id, session_idx) in enumerate(session_identifier):
MarkerStatistics._write_row(
table_writer=table_writer,
sender_id=sender_id,
session_idx=session_idx,
marker_name=marker_name,
statistic_name=MarkerStatistics._add_num_user_turns_str_to(
statistic_name
),
statistic_value=values[record_idx],
)

@staticmethod
def _write_row(
Expand Down