Skip to content

Enforce type annotations in the CI #7513

Closed
@joejuzl

Description

@joejuzl

Type annotations on method definitions are part of our code conventions.
We are seeing lots of PR review comments suggesting adding type annotations.
We should add it to the CI so it is automated.
This will reduce PR review burden, and help maintain our code quality.

Thoughts:

  • Could be done either using mypy or pylint
  • Should only be run on code diffs so we can incorporate it incrementally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:rasa-oss 🎡Anything related to the open source Rasa frameworkarea:rasa-oss/infrastructure 🚅All things related to infrastructure or deploymentstype:maintenance 🔧Improvements to tooling, testing, deployments, infrastructure, code style.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions