Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logger message to debug when plugins not found #995

Merged
merged 5 commits into from
Jul 11, 2023
Merged

fix: logger message to debug when plugins not found #995

merged 5 commits into from
Jul 11, 2023

Conversation

souvikg10
Copy link
Contributor

@souvikg10 souvikg10 commented Jun 26, 2023 •
edited by ancalita
Loading

Proposed changes:

  • Fixes the logger.info when plugins not found to logger.debug

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@souvikg10 souvikg10 requested a review from ancalita June 26, 2023 08:53
ancalita
ancalita reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changelog entry + a unit test for log check? 🙏🏻

@souvikg10 souvikg10 requested a review from ancalita July 3, 2023 14:44
ancalita
ancalita reviewed Jul 4, 2023
View reviewed changes
tests/test_plugin.py Outdated Show resolved Hide resolved
Urkem
Urkem approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@Urkem Urkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ 💯

@ancalita ancalita merged commit 2caaa67 into 3.6.x Jul 11, 2023
13 checks passed
@ancalita ancalita deleted the fix-error-message-plugin branch July 11, 2023 10:36
ancalita pushed a commit that referenced this pull request Jul 12, 2023
@souvikg10 @ancalita
fix: logger message to debug when plugins not found (#995)
17f92bf 
* fix: logger message to debug when plugins not found

* add changelog and test

* fix:lint error

* fix:lint error

* amend test and log format

---------

Co-authored-by: Anca Lita <27920906+ancalita@users.noreply.github.com>
(cherry picked from commit 2caaa67)
@xxm1668
Copy link

xxm1668 commented Oct 10, 2023

ModuleNotFoundError: No module named 'rasa_sdk_plugins'

@souvikg10
Copy link
Contributor Author

@xxm1668 - what is the version you are trying to install? please install rasa-sdk==3.6.2

@xxm1668
Copy link

xxm1668 commented Oct 11, 2023

i find rasa==3.5.0 rasa-sdk==3.5.0,it works!!!

@souvikg10
Copy link
Contributor Author

this change was only implemented in rasa-sdk==3.6.1 however there was a regression which was fixed in rasa-sdk==3.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita left review comments

@Urkem Urkem Urkem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@souvikg10 @xxm1668 @Urkem @ancalita