Add more tests for colour, embeds, files, buttons and modals #9875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test coverage in discord/colour.py improved from 73% to 95%
Test coverage in discord/embeds.py improved from 22% to 80%
Test coverage in discord/embeds.py improved from 81% to 94%
Test coverage in discord/embeds.py improved from 42% to 82%
Improved test coverage for discord/ui/button.py from 35% to 50% and for discord/ui/view.py from 24% to 34%.
3 tasks
Rapptz
approved these changes
Oct 9, 2024
| (discord.Colour.pink(), 0xEB459F), | ||
| ], | ||
| ) | ||
| def test_static_colours(value, expected): |
There was a problem hiding this comment.
I just want to make a note that some of these have changed before, e.g. blurple. I'm not sure what the API stability on these are but we have changed them where it makes sense historically. This has no bearing on the tests being here but I just wanted to comment on it.
|
Sorry for the late response on this PR, huge backlog. Thanks for the PR though, it's appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added more test case for colour, embeds, files, buttons and modals
Checklist