Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharding Guide #9562

Open
wants to merge 17 commits into
base: docs/guide
Choose a base branch
from
Open

Conversation

Hadock-is-ok
Copy link

Summary

Guide on Sharding and how to do so,
Co-Authored-By @nihaals (#7499)

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Hadock-is-ok Hadock-is-ok marked this pull request as draft September 14, 2023 10:41
@Hadock-is-ok Hadock-is-ok marked this pull request as ready for review September 27, 2023 16:19
@Hadock-is-ok
Copy link
Author

Hadock-is-ok commented Sep 27, 2023

I forgot to swap this from draft to ready to review (I know this is still incomplete but I do not know what else to add.)

docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
Hadock-is-ok and others added 2 commits October 1, 2023 20:50
Co-authored-by: Willy <19799671+Willy-C@users.noreply.github.com>
Co-authored-by: Willy <19799671+Willy-C@users.noreply.github.com>
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start just a few comments from myself.

The PR comments themselves and some more:-

  • It'd be good to have a strongly worded footnote or small end-of-topic go-over of the sharding formula and why it's necessary.
  • There seems to be no mention of the DM limitation, that Shard 0 is the only shard to receive DMs.
  • More explanation on the shard_count and shard_ids parameters of the constructors of the relevant classes. It's okay to mention them but I'd like to understand them better, at least at a glance.

docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
docs/guide/topics/sharding.rst Show resolved Hide resolved
docs/guide/topics/sharding.rst Outdated Show resolved Hide resolved
Hadock-is-ok and others added 9 commits January 27, 2024 22:06
Co-authored-by: Alex Nørgaard <Umbra@AbstractUmbra.dev>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
(I don't know what to put as the title)

Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

6 participants