Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] app commands guide #9557

Draft
wants to merge 41 commits into
base: docs/guide
Choose a base branch
from

Conversation

ika2kki
Copy link
Contributor

@ika2kki ika2kki commented Sep 11, 2023

Summary

app commands guide drafting
i have a built version hosted here to make it accessible if you want to read it https://saya.kessoku.moe/discord.py/guide/interactions/slash_commands.html
it can be slightly old if i forgot to update it after a commit.
so far, i am kinda happy with the content but not so much the overall writing tone

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Contributor

@tailoric tailoric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through it once and annotated what I've found and gave some opinions
However, I skimmed the translation part only, since I have no experience in that area.

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore the comments about decorators (IDR what other guides do)

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
ika2kki and others added 2 commits December 3, 2023 22:02
Co-Authored-By: Noelle Wang <73260931+no767@users.noreply.github.com>
Copy link

@No767 No767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks pretty good to me. There are a couple of minor phrasing issues that should be pointed out

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved
docs/guide/interactions/slash_commands.rst Show resolved Hide resolved
Copy link

@No767 No767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at the recent changes, and they all look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

6 participants