Skip to content

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Sep 18, 2025

Summary

This PR does the following:

  • Add support for the new FileUpload component for modals
    • Added an example for the new component
  • Add missing required kwarg to Channel/Mentionenable/Role/UserSelect classes
  • Parse the resolved data from the modal submit interaction for selects and the new component
    • Fix Channel/Mentionenable/Role/UserSelect.values returning a list of ids instead of the relevant objects
  • Fix not being able to submit a Modal with TextDisplays
  • Correct various docstrings for Modal related components

Relevant references:

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Contributor

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks

@Soheab Soheab force-pushed the components/file-upload branch 2 times, most recently from ee2c423 to 18fe654 Compare September 21, 2025 14:39
@Soheab Soheab force-pushed the components/file-upload branch from 18fe654 to 8b7162c Compare September 21, 2025 14:46
@Soheab Soheab force-pushed the components/file-upload branch from 8b7162c to 322d7e1 Compare September 21, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants