-
Notifications
You must be signed in to change notification settings - Fork 0
feat(benchmark): expose vote aggregation on leaderboards #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RapidPoseidon
merged 3 commits into
main
from
feat(benchmark)/expose-vote-aggregation-on-leaderboards
Aug 14, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -66,6 +66,7 @@ | |
| DeviceType, | ||
| Tag, | ||
| Origin, | ||
| VoteAggregation, | ||
| Datapoint, | ||
| ContextManager, | ||
| FailedUploadException, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
src/rapidata/rapidata_client/benchmark/leaderboard/vote_aggregation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| from enum import Enum | ||
|
|
||
| from rapidata.api_client.models.vote_aggregation import ( | ||
| VoteAggregation as VoteAggregationModel, | ||
| ) | ||
|
|
||
|
|
||
| class VoteAggregation(Enum): | ||
| """VoteAggregation Enum | ||
|
|
||
| How the individual annotator responses on a single matchup (one comparison of | ||
| two models on one prompt) are aggregated into that matchup's result. | ||
|
|
||
| Attributes: | ||
| MAJORITY_VOTE (VoteAggregation): Collapses each matchup to a single win for | ||
| the side the majority of responses picked, splitting ties 0.5/0.5. | ||
| ALL_VOTES (VoteAggregation): Counts every individual response as its own | ||
| matchup. | ||
| """ | ||
|
|
||
| MAJORITY_VOTE = VoteAggregationModel.MAJORITYVOTE | ||
| ALL_VOTES = VoteAggregationModel.ALLVOTES | ||
|
|
||
| def _to_backend_model(self) -> VoteAggregationModel: | ||
| return VoteAggregationModel(self.value) | ||
|
|
||
| @classmethod | ||
| def _from_backend_model(cls, model: VoteAggregationModel) -> "VoteAggregation": | ||
| return cls(model) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't make this sound so negatively. i think it's fine if for now we just mention that the matchup winner is chosen by majority vote without going into too much detail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toned down in d474c7b. Dropped the comparison table and the "this is what you want in almost every case" framing; it now just states that the matchup winner is the side the majority picked (ties split 0.5/0.5) and shows how to opt out:
I kept the note that switching it re-counts already-collected responses, since that is genuinely surprising and easy to get wrong — happy to cut it too if you think it is more detail than the page needs.