-
Notifications
You must be signed in to change notification settings - Fork 9
changed dispatcher port to 5001 #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
rapidfireai/evals/utils/constants.py
Outdated
| # Dispatcher Constants | ||
| DISPATCHER_HOST = "127.0.0.1" | ||
| DISPATCHER_PORT = 5000 | ||
| DISPATCHER_PORT = 8851 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Port Conflict: Dispatcher Ports Mismatched, Needs Alignment
Port conflict: The evals dispatcher is configured to use port 8851, which is the same port used by the fit dispatcher (defined in rapidfireai/fit/utils/constants.py line 48). This creates a port conflict when both systems run simultaneously. According to the PR description, the evals dispatcher should be changed to port 5001 to avoid conflicts, but it was incorrectly changed to 8851 instead.
| "<a href=\"https://rapidfire.ai/\"><img src=\"https://raw.githubusercontent.com/RapidFireAI/rapidfireai/main/docs/images/RapidFire - Blue bug -white text.svg\" width=\"115\"></a>\n", | ||
| "<a href=\"https://discord.gg/6vSTtncKNN\"><img src=\"https://raw.githubusercontent.com/RapidFireAI/rapidfireai/main/docs/images/discord-button.svg\" width=\"145\"></a>\n", | ||
| "<a href=\"https://oss-docs.rapidfire.ai/\"><img src=\"https://raw.githubusercontent.com/RapidFireAI/rapidfireai/main/doc/imagesmages/documentation-button.svg\" width=\"125\"></a>\n", | ||
| "<a href=\"https://oss-docs.rapidfire.ai/\"><img src=\"https://raw.githubusercontent.com/RapidFireAI/rapidfireai/main/docs/imagesmages/documentation-button.svg\" width=\"125\"></a>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed Evals Dispatcher port to 5001 to avoid conflicts
Note
Standardizes service ports to 8851/8852/8853 and replaces hardcoded URLs with config classes, updating startup scripts, workflows, frontend proxies/tests, and documentation accordingly.
DispatcherConfig,MLFlowConfig,FrontendConfigacross fit/evals; replace hardcoded URLs with*.URL.dispatcher8851,mlflow8852,frontend8853; CORS origins updated accordingly.setup/fit/start.sh,setup/fit/start_dev.sh):RF_LOG_PATHand route logs there; improve readiness checks/status; cleanup and environment handling.craco.config.js), Flask server updated; proxies (setupProxy.js,proxy_middleware.py) target new config URLs.setup/bump_version.sh; manual deploy outputsnew_numeric_versionand echoes version-specific PyPI URL.pyproject.toml: relax/adjust dependency versions; add project URLs and package data.cli.install_packages: addfaiss-gpu-cu12for CUDA 12 evals.Written by Cursor Bugbot for commit 1f8e174. This will update automatically on new commits. Configure here.