-
Notifications
You must be signed in to change notification settings - Fork 15
Multi-GPU FSDP Support #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…o feature/multi-gpu
| self.db.set_ic_ops_task_status( | ||
| run_state["task_id"], TaskStatus.COMPLETED | ||
| ) | ||
| self.db.set_ic_ops_task_status( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't lines 300-302 is just repeating 297-299?
| self.db.set_ic_ops_task_status( | ||
| run_state["task_id"], TaskStatus.COMPLETED | ||
| ) | ||
| self.db.set_ic_ops_task_status( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 LOC repeated again
| self.db.set_ic_ops_task_status( | ||
| run_state["task_id"], TaskStatus.COMPLETED | ||
| ) | ||
| self.db.set_ic_ops_task_status( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 LOC repeated again
| self.logger.warning( | ||
| f"Run {run_id} is already completed. Skipping Interactive Control task." | ||
| ) | ||
| self.logger.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 LOC repeated again
| config_leaf["additional_kwargs"] = parent_run_details["config_leaf"][ | ||
| "additional_kwargs" | ||
| ] | ||
| config_leaf["additional_kwargs"] = parent_run_details["config_leaf"][ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 LOC repeated again
| raise ControllerException( | ||
| f"Error creating model for run {parent_run_id}: {e}" | ||
| ) from e | ||
| self.ic_logger.error( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 LOC repeated again
| self.ic_logger.warning( | ||
| f"Ignoring RESUME/STOP task for run {run_id} as it is already completed" | ||
| ) | ||
| self.ic_logger.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 LOC repeated again
arun-rfai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through all code changes and new notebooks. Looks good to me except for one minor typo issue in controller.py: several lines of code are repeated here and there. I have marked up the locations with comments. Resolve those before merging.
Summary
Key changes:
Testing:
Single-GPU (regression): Ran all original lite notebooks - no regressions
Multi-GPU FSDP: