Fixes#3
Open
mjesun wants to merge 3 commits intoRapid-Application-Development-JS:masterfrom
mjesun:fixes
Open
Conversation
Author
|
Oops, I just noticed itemplate, as what appears to be a newer version of it. Should I move mi PR to that one instead? |
|
Thank you for your observations! At the moment we are making corrections in itemplate library, which will correspond to the rules of writing gulp plugins. The problems that you've specified will also be corrected there. After the transition of itemplate to html2 parcer we'll use your pool request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been playing with the compiler and found some easy-to-fix problems:
\nin attributes,"or'). All escaping is done now viaJSON.stringify, which creates a correctly escaped representation of a given string.<or>used after an evaluation expression was not interpreted as text. This is because the lastevaluatetag was kept in memory (_currentTag), thus making the code think that the following text did not need any escaping.<and>inside evalutation blocks, so<=is not wrongly understood as an opening tag by thehtmlparseranalyzer.