Skip to content

Fixes#3

Open
mjesun wants to merge 3 commits intoRapid-Application-Development-JS:masterfrom
mjesun:fixes
Open

Fixes#3
mjesun wants to merge 3 commits intoRapid-Application-Development-JS:masterfrom
mjesun:fixes

Conversation

@mjesun
Copy link

@mjesun mjesun commented Oct 11, 2015

I've been playing with the compiler and found some easy-to-fix problems:

  • Compilation of special characters (like \n in attributes, " or '). All escaping is done now via JSON.stringify, which creates a correctly escaped representation of a given string.
  • A bug where < or &gt used after an evaluation expression was not interpreted as text. This is because the last evaluate tag was kept in memory (_currentTag), thus making the code think that the following text did not need any escaping.
  • Pre-escape < and > inside evalutation blocks, so <= is not wrongly understood as an opening tag by the htmlparser analyzer.

@mjesun
Copy link
Author

mjesun commented Oct 11, 2015

Oops, I just noticed itemplate, as what appears to be a newer version of it. Should I move mi PR to that one instead?

@YLuchaninov
Copy link

Thank you for your observations! At the moment we are making corrections in itemplate library, which will correspond to the rules of writing gulp plugins.

The problems that you've specified will also be corrected there. After the transition of itemplate to html2 parcer we'll use your pool request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants