-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #63, #54, #62, and #101 #121
Conversation
// This ensures that when it's reloaded it won't try to set | ||
// its default inventory. Instead it will persist the fact | ||
// that all the items were removed from it | ||
if (!this.inventory.size) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getting rid of the null inventory is a blessing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we get rid of a few more things with this inventory fix?
Like equip() Remove the 'if this.inventory' check? line 365
Cant we just use _setupInventory in the constructor and pass in the inventory with the data? Then we can get rid of all the extra _setupInventory calls in Character.js
Can do the same in Item.js, have a single setupInventory and not have to have checks in all the other places.
@nelsonsbrian I totally agree, so I just added those changes for |
I rolled back those |
Room.exits
for documentation purposes.Character.unfollow()
this.keywords
when spawning aNpc
effect.state
before adding to an entity