Fix #63, #54, #62, and #101 #121
Conversation
azigler
changed the title
| // This ensures that when it's reloaded it won't try to set | ||
| // its default inventory. Instead it will persist the fact | ||
| // that all the items were removed from it | ||
| if (!this.inventory.size) { |
There was a problem hiding this comment.
getting rid of the null inventory is a blessing
There was a problem hiding this comment.
Can't we get rid of a few more things with this inventory fix?
Like equip() Remove the 'if this.inventory' check? line 365
Cant we just use _setupInventory in the constructor and pass in the inventory with the data? Then we can get rid of all the extra _setupInventory calls in Character.js
Can do the same in Item.js, have a single setupInventory and not have to have checks in all the other places.
|
@nelsonsbrian I totally agree, so I just added those changes for |
|
I rolled back those |
Room.exitsfor documentation purposes.Character.unfollow()this.keywordswhen spawning aNpceffect.statebefore adding to an entity