Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EffectFactory fixes #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

EffectFactory fixes #105

wants to merge 3 commits into from

Conversation

Sakeran
Copy link
Contributor

@Sakeran Sakeran commented Sep 26, 2019

This fixes an issue where a missing reference in EffectFactory#get would cause the method to call itself infinitely.

It also adds a docstring to EffectFactory#has, mirroring the one set on AttributeFactory#has

@Sakeran
Copy link
Contributor Author

Sakeran commented Sep 26, 2019

Updated the return value of EffectFactory#get to return just the effect definition. Judging by the method's docstring, I'm assuming this is the intended behavior.

azigler added a commit to azigler/core that referenced this pull request Jun 7, 2020
@azigler
Apply relevant improvements
75ecb94 
- improve docstrings
- use RanvierMUD#74, RanvierMUD#93, RanvierMUD#98, RanvierMUD#100, RanvierMUD#103, RanvierMUD#106, RanvierMUD#109, RanvierMUD#117, RanvierMUD#104, RanvierMUD#119, RanvierMUD#105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sakeran