update EntityFactory types + compiling errors #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also updated some types that were failing on build |
nelsonsbrian
commented
May 28, 2023
| keywords: string[]; | ||
| quests?: EntityReference[]; | ||
| uuid?: string; | ||
| } | ||
|
|
||
| export class Npc extends Scriptable(Character) { |
There was a problem hiding this comment.
Scriptable is already in Character and this was causing some circular dependency issues I believe
There was a problem hiding this comment.
I think you're right about this -- I forget if I fixed this the same way locally but I definitely ran into it. Good call
nelsonsbrian
commented
May 28, 2023
| "@types/winston": "^2.4.4", | ||
| "@types/ws": "^7.4.5", | ||
| "bcryptjs": "^2.4.0", | ||
| "commander": "^4.1.0", |
There was a problem hiding this comment.
had a compile error from commander in the node_modules. We only use the 'types' in core-ts, so just upgraded to the real package (as the types are just a stub) until the error went away.
seanohue
reviewed
May 28, 2023
| @@ -376,11 +378,14 @@ export class BundleManager { | |||
| * @param {EntityFactory} factory | |||
| * @return {Array<string>} | |||
| */ | |||
| async loadEntities( | |||
| async loadEntities< | |||
There was a problem hiding this comment.
good use of generics here
seanohue
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some EntityFactory types on my repo, so transferred the work I did to here.
There is some wonky assumptions made between the property of id/entityReference/area between the Area + Item/Npc/Room that some of them use some of those properties, and some others.
I think this gets us 1 step closer to true types and less type bypassing.