Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw type system support for strings #85

Merged
merged 4 commits into from
Oct 14, 2018
Merged

Raw type system support for strings #85

merged 4 commits into from
Oct 14, 2018

Conversation

Rantanen
Copy link
Owner

The raw type system uses raw C-strings (null terminated strings with 1-byte characters). This isn't necessarily the final form and is up for debate, but I wanted some sort of support for raw type system strings so we can test the type system infrastructure works.

On the other hand I do feel there is some value in supporting C-strings as well. I wonder if it would make sense to support 3 type systems instead of the current two:

  • Automation
  • Raw (C-type system)
  • Intercom (Length prefixed C-strings for performance reasons)

@codecov-io
Copy link

codecov-io commented Oct 13, 2018

Codecov Report

Merging #85 into master will increase coverage by 0.22%.
The diff coverage is 68.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   73.82%   74.05%   +0.22%     
==========================================
  Files          55       55              
  Lines        3889     4012     +123     
==========================================
+ Hits         2871     2971     +100     
- Misses       1018     1041      +23
Impacted Files Coverage Δ
intercom/src/lib.rs 45.45% <ø> (ø) ⬆️
intercom-common/src/generators/cpp.rs 80.98% <100%> (+0.06%) ⬆️
intercom-common/src/generators/idl.rs 82.31% <100%> (+0.06%) ⬆️
intercom/src/strings.rs 68.07% <58.76%> (+0.87%) ⬆️
intercom-common/src/returnhandlers.rs 85.71% <75%> (-0.5%) ⬇️
intercom-common/src/tyhandlers.rs 80.36% <93.1%> (+3.77%) ⬆️
intercom/src/alloc.rs 80.48% <0%> (+14.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4dbf1e...069d1c5. Read the comment docs.

Testing various automatic BString<->CString conversions
@Rantanen Rantanen merged commit 148724a into master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants