Skip to content

Commit

Permalink
Fix warnings in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mfontanini committed Oct 2, 2017
1 parent f2766db commit 2aab4cf
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions tests/src/ip_address_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,6 @@ TEST(IPAddressTest, Mask) {
}

TEST(IPv4AddressTest, Size) {
EXPECT_EQ(4, IPv4Address("127.0.0.1").size());
EXPECT_EQ(4, IPv4Address().size());
EXPECT_EQ(4UL, IPv4Address("127.0.0.1").size());
EXPECT_EQ(4UL, IPv4Address().size());
}
4 changes: 2 additions & 2 deletions tests/src/ipv6_address_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ TEST(IPv6AddressTest, MaskAddress) {
}

TEST(IPv6AddressTest, Size) {
EXPECT_EQ(16, IPv6Address("dead:beef::1").size());
EXPECT_EQ(16, IPv6Address().size());
EXPECT_EQ(16UL, IPv6Address("dead:beef::1").size());
EXPECT_EQ(16UL, IPv6Address().size());
}

#if TINS_IS_CXX11
Expand Down
4 changes: 2 additions & 2 deletions tests/src/ipv6_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ TEST_F(IPv6Test, OptionIteration) {
IPv6& ipv6 = pkt.rfind_pdu<IPv6>();
const IPv6::headers_type& headers = ipv6.headers();

ASSERT_EQ(1, headers.size());
ASSERT_EQ(1UL, headers.size());
const IPv6::ext_header& header = headers[0];
EXPECT_EQ(IPv6::ROUTING, header.option());
}
Expand All @@ -349,7 +349,7 @@ TEST_F(IPv6Test, OptionAddition) {

const IPv6::headers_type& headers = ipv6.headers();

ASSERT_EQ(2, headers.size());
ASSERT_EQ(2UL, headers.size());
EXPECT_EQ(IPv6::ROUTING, headers[0].option());
EXPECT_EQ(IPv6::AUTHENTICATION, headers[1].option());

Expand Down
2 changes: 1 addition & 1 deletion tests/src/pdu_iterator_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class PDUIteratorTest : public testing::Test {

const PDU& pdu = *iterate_pdus(ip).begin();
EXPECT_EQ(PDU::IP, pdu.pdu_type());
EXPECT_GT(const_cast<PDU&>(pdu).serialize().size(), 0);
EXPECT_GT(const_cast<PDU&>(pdu).serialize().size(), 0UL);
}
};

Expand Down

0 comments on commit 2aab4cf

Please sign in to comment.