Jango/minor improvements #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobody5050
requested changes
Oct 14, 2023
Member
nobody5050
left a comment
nobody5050
left a comment
There was a problem hiding this comment.
Looks good except for this typo
Member
|
Oh also, following up on what lumin had suggested; making things return none instead of crashing in some instances |
Contributor
Author
I'm not sure which parts you are referring to, there are many ways to cause runtime errors. |
Member
|
Specifically what lumin mentioned, accessing a variable that doesn’t exist |
nobody5050
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few minor things that we discussed, along with fixing a few typos and mistakes.