Fixing Audio script referencing static download path. #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed.cong downloadPath var
|
This should be using importPath and not downloadPath if your going to adjust it. Please change it to importPath and I'll merge it. Thanks edit: Good Catch |
RandomNinjaAtk
requested changes
Jul 4, 2024
ghost
requested a review
from 
|
Thanks for catching that! Appreciate the work! |
RandomNinjaAtk
approved these changes
Jul 4, 2024
|
Thx for the contribution and good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving audio script to use the downloadPath variable instead of statis path.
This is causing issues with docker images if the path is not mounted as a volume as per the default settings.