Skip to content

Updated QueueCleaner #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Updated QueueCleaner #267

wants to merge 1 commit into from

Conversation

baxterblk
Copy link

Added functions to remove stalled downloads from torrent client

@baxterblk
Copy link
Author

@RandomNinjaAtk Please review

@RandomNinjaAtk
Copy link
Owner

RandomNinjaAtk commented Jun 7, 2024

Just from a quick review, it looks like you mostly rewrote it.. But honestly after reviewing, I don't see how it does anything differently for torrents.... You appear to be using the same exact command to remove the stalled item from queue that I was using in my version....

Other than a refactor/rewrite, please explain what it does differently.

Edit: After further, more detailed review, I see that your pulling items with the status of "stalled", which is the primary difference other than a complete rewrite for the most part...

RandomNinjaAtk added a commit that referenced this pull request Jun 7, 2024
#267 - Based on reviewing this PR, I have updated the script to accommodate the request without the need for a complete re-write and removal of existing functionality.

Additionally, this should now support any port... Has had limited testing...
@RandomNinjaAtk
Copy link
Owner

I updated the script to account for "stalled" items. Please give the update I just pushed a try to see if it now handles your request.

@RandomNinjaAtk
Copy link
Owner

If you confirm the latest changes resolves this PR, please let me know. I appreciate that you took the time to refactor/rewrite it but you removed some of the functionality and and what was needed to handle your request was only a couple of additional lines, so the rewrite wasn't needed.

I also resolved port constraint issues and did some minor refactoring at the same time.

@baxterblk
Copy link
Author

That works for me! Thank you.

@RandomNinjaAtk
Copy link
Owner

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants