More idiomatic elmentary benchmark code #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, however writing It was originally coded that way until unit testing revealed it is malformed. If you can fix it in your repo I'll happily merge this. |
RandomHashTags
requested review from
RandomHashTags
and removed request for
RandomHashTags
|
oops, I totally missed that. should be good now. if you need help setting up CI in github actions, let me know. |
|
I guess that works too. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect much in terms of performance, but I think this way the code is a) more comparable to others, and b) more idiomatic to how elementary wants to be written.