Repository navigation
feat: verify configuration review before host changes - #109
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6237424cea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unprotected private desired-state branch can reach controller reconciliation without completed hosted checks or independent review. Add an opt-in check in the trusted installed engine before accepting configuration, using a separately provisioned root-owned policy and activation marker outside candidate Git.
The verifier requires a unique merged PR result, exact applied/reviewed tree equality, inclusion of the applied commit's previous main parent in the reviewed head, a formal allowed-reviewer approval on the full PR head from someone other than the author, and successful pinned-workflow/jobs on the applied SHA and latest attempt. It rejects direct pushes, stale/self/dismissed reviews, outstanding trusted change requests, failed/missing/skipped checks, identity/tree mismatches, redirects, malformed/unavailable API evidence, and pagination/deadline overflow. Effective review decisions are ordered by submission time, including previously pending reviews. Approvals must follow any PR base retargeting, verified through a bounded base-change timeline query. Existing hosts reject older-commit replay or divergence using their trusted installed-state ancestry, and independently verify every integrated first-parent commit since that baseline. Incomplete history or more than twenty integrated commits fails closed. A root-owned saved LKG record provides an inherited-lock health-recovery context, including policy-action resume, while the engine capability guard remains required. Credentials enter through stdin and errors omit API/policy contents.
Wire the check into remote reconciliation, unchanged/drift paths, direct check/install/adopt/upgrade, and policy-action resume. Enabled hosts reject an engine selection or checkpoint rollback that drops approval capability. Preserve root-owned policy and marker across rollback/uninstall. Existing installations remain unchanged until separately authorized opt-in activation. Document the existing root-owned installation/checkpoint recovery baseline and host-root/trusted-engine trust limits.
Ship the capability, exact-key policy validator, fictional example, installer/reconciler tests, validation entrypoint, and operator/App-permission guidance together. Installer fixtures isolate simulated load from the shared test machine and release the fake runner after the nested drain returns, removing a cleanup race. Production health thresholds are unchanged.
Validation so far: 29 approval tests, 28 desired-state tests, 38 reconciler tests, shellcheck/syntax, capability validation, documentation links, and tracked/committed secret scans passed. The required hosted workflow runs the full installer suite and image contract. Docker is unavailable locally. See current-head required checks and resolved review threads for final integration evidence; applicable review and checks are required before integration.
Closes #108 for engine implementation. This PR does not authorize App permission changes, reviewer provisioning, root policy files, adoption of an engine pin, SSH, timers, live host work, or production deployment. A bot completion summary/reaction alone is not a formal approval, and existing hosts are not protected until the separate adoption is proven.