fix(gate): bound control-plane tests against the query timeout, not the runner - #222
Merged
Conversation
…he runner TestSamplerShutdownBoundedWithStuckScrape asserted shutdown finished within 3s of a 500ms control timeout, and failed at 3.55s on a loaded CI runner (PR #133). The property these tests exist to prove is that the 600s query-client timeout does not govern readiness polling or sampler shutdown; a tight bound measures runner contention instead. Both bounds move to 60s, which still fails decisively if the long client leaks in.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestSamplerShutdownBoundedWithStuckScrapefailed at 3.55s against its own 3s assertion on a loaded CI runner, blocking PR #133. My defect, introduced with the client split in #218.The bound was wrong in kind, not just in size: these two tests exist to prove the 600s query client's timeout does not govern readiness polling or sampler shutdown. Asserting proximity to the 500ms control timeout measures runner scheduling, not that property. Both bounds move to 60s — still an immediate, decisive failure if the long client leaks into the control path, with no sensitivity to contention.
go test -tags gate -race ./test/gate/...green locally.