WIP: #15: Added review command #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamonGebben
force-pushed
the
15_review_command
branch
from
9747b82 to
07a0f59
Compare
alxbrg
reviewed
Apr 25, 2018
alxbrg
left a comment
alxbrg
left a comment
There was a problem hiding this comment.
Besides the commented out lines, LGTM.
lib/commands/review/index.js
Outdated
| logger.log('No git'); | ||
| } | ||
|
|
||
| // return process.exit(0); |
lib/utils/readConfig/index.js
Outdated
| return _config; | ||
| }) | ||
| .catch(() => { | ||
| // logger.log(err.message); |
Collaborator
|
The branch has conflicts btw |
Collaborator
|
Looks pretty good. As usual, I'm learning quite a bit by reading your code :). I do have some high level comments though |
Owner
Author
|
I've noticed that the tests are flaud because of mock-fs. I'm currently trying to figure out a workaround for this problem. Will process the comments as well. |
added 2 commits
April 29, 2018 12:18
Collaborator
|
Yo @RamonGebben I fixed the merge conflicts for you <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added review command mentioned in #15
@alxbrg can you test this and see if it works for you?
TODO: