We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have many instances like this:
fmt.Errorf("drpc " + drpcName + " is not ready yet before timeout, fail")
Should use:
fmt.Errorf("drpc %q is not ready yet before timeout, fail", drpcName)
Notes: Use %q to get clear values in logs, and detect values with leading or trailing whitespace
The text was updated successfully, but these errors were encountered:
hi, can i work on this?
Sorry, something went wrong.
@alonsofabila-dev sure, welcome to ramen!
If you want to test you changes locally see https://github.com/RamenDR/ramen/blob/main/docs/devel-quick-start.md
If you have issues setting up testing environment locally, our CI will run your changes with one.
this changes are only under the e2e directory?
We may have the same issue in other places, but I think it is best to focus on the e2e directory for now.
Fixes: RamenDR#1618
3978f33
e2e change improper use of formatting Signed-off-by: alonso fabila <jorge.fabila@encora.com>
No branches or pull requests
We have many instances like this:
Should use:
Notes: Use %q to get clear values in logs, and detect values with leading or trailing whitespace
The text was updated successfully, but these errors were encountered: