Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Improper use of error formatting #1618

Open
nirs opened this issue Oct 28, 2024 · 4 comments
Open

e2e: Improper use of error formatting #1618

nirs opened this issue Oct 28, 2024 · 4 comments
Labels
good first issue Good for newcomers test Testing related issue

Comments

@nirs
Copy link
Member

nirs commented Oct 28, 2024

We have many instances like this:

fmt.Errorf("drpc " + drpcName + " is not ready yet before timeout, fail")

Should use:

fmt.Errorf("drpc %q is not ready yet before timeout, fail", drpcName)

Notes: Use %q to get clear values in logs, and detect values with leading or trailing whitespace

@nirs nirs added good first issue Good for newcomers test Testing related issue labels Oct 28, 2024
@alonsofabila-dev
Copy link

hi, can i work on this?

@nirs
Copy link
Member Author

nirs commented Oct 28, 2024

@alonsofabila-dev sure, welcome to ramen!

If you want to test you changes locally see https://github.com/RamenDR/ramen/blob/main/docs/devel-quick-start.md

If you have issues setting up testing environment locally, our CI will run your changes with one.

@alonsofabila-dev
Copy link

this changes are only under the e2e directory?

@nirs
Copy link
Member Author

nirs commented Oct 28, 2024

this changes are only under the e2e directory?

We may have the same issue in other places, but I think it is best to focus on the e2e directory for now.

alonsofabila-dev added a commit to alonsofabila-dev/ramen that referenced this issue Oct 28, 2024
e2e change improper use of formatting

Signed-off-by: alonso fabila <jorge.fabila@encora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing related issue
Projects
None yet
Development

No branches or pull requests

2 participants