-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e flake: starting test fails with panic: runtime error: index out of range [0] with length 0 #1562
Comments
nirs
added a commit
to nirs/ramen
that referenced
this issue
Oct 28, 2024
Using the same algorithm used by drenv/test.lookup_cluster: - Wait for the placement Satisfied condition - Find the placement decision using using the label selector We know that this works. In some case we can optimize by getting the placement decision name from the placement without listing, but this does not work in all cases so lets keep the code simpler. Fixes RamenDR#1562 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Oct 28, 2024
Using the same algorithm used by drenv/test.lookup_cluster[1]: - Wait for the placement Satisfied condition - Find the placement decision using using the label selector We know that this works. In some case we can optimize by getting the placement decision name from the placement without listing, but this does not work in all cases so lets keep the code simpler. [1] https://github.com/RamenDR/ramen/blob/2886c647e9c465f5fe7a8665e53c37de002b6326/test/drenv/test.py#L204 Fixes: RamenDR#1562 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Oct 28, 2024
We cannot use the method we used in drenv/test.lookup_cluster[1] since placement Satisfied condition is not set in discovered apps flows. Simplify the code to wait until we have placement decisions status contains non empty decisions list. [1] https://github.com/RamenDR/ramen/blob/2886c647e9c465f5fe7a8665e53c37de002b6326/test/drenv/test.py#L204 Fixes: RamenDR#1562 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Oct 28, 2024
We cannot use the method we used in drenv/test.lookup_cluster[1] since placement Satisfied condition is not set in discovered apps flows. Simplify the code to wait until we have placement decisions status contains non empty decisions list. [1] https://github.com/RamenDR/ramen/blob/2886c647e9c465f5fe7a8665e53c37de002b6326/test/drenv/test.py#L204 Fixes: RamenDR#1562 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Oct 28, 2024
We cannot use the method we used in drenv/test.lookup_cluster[1] since placement Satisfied condition is not set in discovered apps flows. Simplify the code to wait until we have placement decisions status contains non empty decisions list. [1] https://github.com/RamenDR/ramen/blob/2886c647e9c465f5fe7a8665e53c37de002b6326/test/drenv/test.py#L204 Fixes: RamenDR#1562 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Oct 28, 2024
We cannot use the method we used in drenv/test.lookup_cluster[1] since placement Satisfied condition is not set in discovered apps flows. Simplify the code to wait until we have placement decisions status contains non empty decisions list. [1] https://github.com/RamenDR/ramen/blob/2886c647e9c465f5fe7a8665e53c37de002b6326/test/drenv/test.py#L204 Fixes: RamenDR#1562 Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I see this failure many times when running the tests in the first time with a new environment. Typically the next tries work. Looks like incorrect setup that fixes itself on the next run since a resource was created on the cluster in the failed attempt.
We can add a retry for the entire test suite, it is faster to rerun the tests than to create a new environment.
The text was updated successfully, but these errors were encountered: