forked from manveru/ramaze
-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Description
In lib/innate/adapter.rb#self.start_webrick,
config = {
:BindAddress => config[:Host],
:Port => config[:Port],
:Logger => Log,
}should be:
config = {
:Host => config[:Host],
:Port => config[:Port],
:Logger => Log,
}because Rack expects to find it there and moves it to :BindAddress in
lib/rack/handler/webrick.rb#self.run, as you can see below:
def self.run(app, options={})
environment = ENV['RACK_ENV'] || 'development'
default_host = environment == 'development' ? 'localhost' : '0.0.0.0'
options[:BindAddress] = options.delete(:Host) || default_host
options[:Port] ||= 8080
@server = ::WEBrick::HTTPServer.new(options)
@server.mount "/", Rack::Handler::WEBrick, app
yield @server if block_given?
@server.start
endWhat this means is, if you're running Ramaze on a remote server, the bug causes the :BindAddress to default to localhost, so your browser won't see the site.
2016-05-12 Fixed in Innate PR 754a7a7
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels