-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions for improved button handling #2
Comments
Hi, I will look into a better handling for the button presses. I'll update when I have a chance to look at implementing this :) |
Hi, |
As far as I know the latest release should improve buttons dramatically. |
Finally got around to trying the latest release. That is excellent, and a much nicer and responsive input process. |
Glad to hear its better, It was actually fairly simple. |
…-Version-rule-and-format
…-Version-rule-and-format
…-buttons PR #2 - Tip temp change short and long press and reverse +- button
This system is so much better than the factory code that I installed it on the first day. Perhaps that's the geek in me, but then that's why I bought the TS100!
Re the button detection and usage...
I can see that using a timer based detection solves debounce issues nicely, but it makes changing values a bit hit-and-miss. When you try and change any value by a single increment it's a case of trying to judge the perfect time press, as too short and you have to start again, too long and you do the same dance in the down direction.
Given that at almost any point the button features are performing a single task, would it be feasible to add a flag to indicate "new button press" that is cleared by any code handling that press? This would allow repeated presses to be handled instantly, bypassing the need to hold the button to go up 50°.
Detection of the button being released can also be used to reset the initial state, so the original time detection can be retained if you feel it's needed.
I guess if detection of double-presses is an issue then the button pressed flag could be triggered by the release, rather than the press.
Just a suggestion, as the button press stuff is the only minor niggle I had.
The text was updated successfully, but these errors were encountered: