-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add item endpoint #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
RakuJa
commented
Jul 10, 2024
- add "total number of element" field in response, to help FE paginate. This is different from count. count only tells the current pagination number, total the sum for all the paginations;
- solve filter bug ignoring pf version
- add item shop listing
- add random item listing generator
- fix ranged/melee bug (they were exclusive, while a creature can be both melee and ranged)
- add weapon, armor, shield sub structure of item
- update dockerfile to work with libraries update (missing build dependency)
- add safe guarantees around n of forged items range gen, now it is formally proved that it will not panic and isolated in a method to reduce redundancy.
- filter item by pathfinder version;
- allow upper and lower case alternative for encounter difficulty and pathfinder version.
… backward compatible.
# Conflicts: # cliff.toml # src/db/cr_core_initializer.rs # src/db/data_providers/creature_fetcher.rs # src/db/data_providers/raw_query_builder.rs # src/models/creature/creature_struct.rs # src/models/creature_component/filter_struct.rs # src/models/creature_filter_enum.rs # src/models/encounter_structs.rs # src/models/mod.rs # src/models/pf_version_enum.rs # src/models/routers_validator_structs.rs # src/routes/bestiary.rs # src/services/encounter_service.rs
…elee bug, update libraries, update item struct
# Conflicts: # CHANGELOG.md
… wrong id, update swagger, introduce generic type for weapon with runes (to sell and loot)
…ce. It saves a few seconds in boot (I should really think about a method to save a few minutes, not seconds..)
Closed
TheAsel
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.