fixup! fixup! repl: refactor to avoid unsafe array iteration

RaisinTen · Jan 14, 2021 · 4fab6a8 · 4fab6a8
1 parent 878dbe2
commit 4fab6a8
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -46,6 +46,7 @@ const {
   RegExp,
   RegExpPrototypeTest,
   RegExpPrototypeToString,
+  SafeArrayIterator,
   SafeStringIterator,
   SafeMap,
   SafeSet,
@@ -1870,18 +1871,19 @@ function tryStringify(arg) {
 }
 
 function format(...args) {
-  return formatWithOptionsInternal(undefined, args);
+  return formatWithOptionsInternal(undefined, ...new SafeArrayIterator(args));
 }
 
 function formatWithOptions(inspectOptions, ...args) {
   if (typeof inspectOptions !== 'object' || inspectOptions === null) {
     throw new ERR_INVALID_ARG_TYPE(
       'inspectOptions', 'object', inspectOptions);
   }
-  return formatWithOptionsInternal(inspectOptions, args);
+  return formatWithOptionsInternal(inspectOptions,
+                                   ...new SafeArrayIterator(args));
 }
 
-function formatWithOptionsInternal(inspectOptions, args) {
+function formatWithOptionsInternal(inspectOptions, ...args) {
   const first = args[0];
   let a = 0;
   let str = '';