Add a non-locking repository that makes use of SKIP LOCKED clause in MySQL & PostgreSQL
#1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubkosinski
force-pushed
the
outbox-non-locking-repository
branch
2 times, most recently
from
b314e7d to
7094bda
Compare
Allow to process next batch of records in the repository using locking or non-locking method. Repository should expose only 3 public methods: - with_next_batch - mark_as_enqueued - delete_enqueued_older_than Other implementation details are private. Consumer handler processing records by passing the block to `Repository#with_next_batch` method. Add `-l, --[no-]locking` switch to CLI to allow changing the locking method in the repository (locking is default)
jakubkosinski
force-pushed
the
outbox-non-locking-repository
branch
from
7094bda to
ce9a58f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use faster non-locking repository in Outbox that is using
SELECT ... FOR UPDATE SKIP LOCKEDquery. Such query will skip all locked rows while still returning non-locked ones if present.This allows to stop obtaining any locks prior to fetching the next batch as we could just lock the whole batch of rows while reading them.