18VA near completed #534
Open
18VA near completed #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added default revenue calculation methods to RevenueManager, and a subclass RevenueManager_18VA to provide real stop values for the initialization of each NetworkVertex, possibly depending on train type and company properties. So RevenueManager is no longer a final class. Also the predictionValue() method in dynamic modifiers is now obsolete. Also added a simple Revenue class, that carries two integers for normal and special revenue. For 18VA, special is used for the mine income that goes directly to the company treasury. The intention is to have revenue objects carry all revenues, but for now it is only applied to 18VA.
Contributor
Author
|
This time all checks fail. No clue why. Could one of the 'dependabot' PRs be the cause? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default revenue calculation methods to RevenueManager, and a subclass RevenueManager_18VA to provide real stop values for the initialization of each NetworkVertex, possibly depending on train type and company properties. So RevenueManager is no longer a final class. IMO this makes the predictionValue() method in dynamic modifiers obsolete.
Also added a simple Revenue class, that carries two integers for normal and special revenue. For 18VA, special is used for the mine income that goes directly to the company treasury (as 1837). The intention is to have revenue objects carry all revenues, but for now it is only applied to 18VA.