From simon4 #27
Open
From simon4 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be 'stream'. Fix it. Signed-off-by: Simon Glass <sjg@chromium.org>
If the board does not specify a time out, use 30 seconds, so that we don't hang forever. Signed-off-by: Simon Glass <sjg@chromium.org>
The long list of files produced by the U-Boot build chews up lots of terminal space and obscures any warnings/errors that are present. Build in silent mode instead. Signed-off-by: Simon Glass <sjg@chromium.org>
Add a 'rev' parameter to the 'checkout' and 'build' methods, so the revision (including a commit has) can be chosen. Signed-off-by: Simon Glass <sjg@chromium.org>
It is handy to be able to test the current U-Boot source on a board. At present you have to create a commit first. Add support for making use of a local patch file and applying it to the source before building. With this it is possible to write a script which builds and tests the current source for you. Signed-off-by: Simon Glass <sjg@chromium.org>
This script creates a patch with any local changes, then uses tbot to build U-Boot and open a interactive terminal to the board's console. It is very handy for quick testing. Signed-off-by: Simon Glass <sjg@chromium.org>
It makes sense to configure the source before building it, even if we did not clean out the directory previously. Update the _build() method to do this. Signed-off-by: Simon Glass <sjg@chromium.org>
At present tbot does nothing with the source unless 'clean' is provided. This makes it impossible to do incremental builds, thus making everything take much longer. For quick testing it is useful to switch commands, configure and build. Update the logic to support this. It is still possible to use the 'clean' flag when a clean build is required. Signed-off-by: Simon Glass <sjg@chromium.org>
Add a new 'test' which builds and flashes U-Boot to the board. Signed-off-by: Simon Glass <sjg@chromium.org>
Add a new 'test' which builds and sends U-Boot to the board, typically using the SoC's boot ROM to transmit over USB. This allows fast testing without reflashing a board. The 'send' method must be implemented by the board. Signed-off-by: Simon Glass <sjg@chromium.org>
Is there an option to do this? I want to set it to my dev machine so I can build a commit without pushing it to github, etc.
|
I've pulled in the typo fix; I'll take a look at the remaining patches in more detail in a few days as I'm a bit busy right now. Sorry for the delay ... |
|
OK thanks. Note that the 'clean' patch requires some sort of test change I think, so you may want it done differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a few changes I needed to build and test with tbot.