ravedude: Use a different avrdude config for avrdude 7.X #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config we've been shipping so far was only for avrdude version 6.X. This config does not work when being used with avrdude 7.X versions. As we do not have control over the installed avrdude version at this time, we need to provide different configurations depending on the avrdude version we find. As a stop-gap solution, import the released default config for avrdude 7.3 and attempt using it for all avrdude 7.X versions. In the future, we'll have to rethink this. It is probably a much better solution to simply vendor avrdude entirely.
|
Please give this a try, to see whether it fixes the problem. You can install the patched ravedude like this: cargo install --git https://github.com/rahix/avr-hal --rev 8137707b8783d2bee77f2cec4ff82e4dc0fd02e9 ravedudePaging @weiying-chen, @Johnwf01john, and @vs-mark-graham-smith. |
|
checked this and working OK now. Thanks |
|
Checked this now and also working. Cheers |
|
Thanks 🙏 |
|
(Released ravedude 0.1.7 with this change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config we've been shipping so far was only for avrdude version 6.X. This config does not work when being used with avrdude 7.X versions.
As we do not have control over the installed avrdude version at this time, we need to provide different configurations depending on the avrdude version we find.
As a stop-gap solution, import the released default config for avrdude 7.3 and attempt using it for all avrdude 7.X versions.
In the future, we'll have to rethink this. It is probably a much better solution to simply vendor avrdude entirely.
Fixes #498.