Enable critical-section by default #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new svd2rust code needs `critical-section` for implementing the `Peripherals::take()` function. This means almost all uses of `avr-device` will need it as well. Rename the `critical-section-impl` feature to just `critical-section` and make it a part of the crate's default features.
Rahix
force-pushed
the
critical-section-default
branch
from
290f6f2 to
cf0288f
Compare
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
Apr 30, 2025
avr-device no longer has a `critical-section-impl` feature. Instead it now has a `critical-section` feature that is enabled by default [1]. As such, we can drop the re-exposed feature here. [1]: Rahix/avr-device#195
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
Apr 30, 2025
avr-device no longer has a `critical-section-impl` feature. Instead it now has a `critical-section` feature that is enabled by default [1]. As such, we can drop the re-exposed feature here. [1]: Rahix/avr-device#195
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
Apr 30, 2025
avr-device no longer has a `critical-section-impl` feature. Instead it now has a `critical-section` feature that is enabled by default [1]. As such, we can drop the re-exposed feature here. [1]: Rahix/avr-device#195
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
May 4, 2025
avr-device no longer has a `critical-section-impl` feature. Instead it now has a `critical-section` feature that is enabled by default [1]. As such, we can drop the re-exposed feature here. [1]: Rahix/avr-device#195
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
May 5, 2025
avr-device no longer has a `critical-section-impl` feature. Instead it now has a `critical-section` feature that is enabled by default [1]. As such, we can drop the re-exposed feature here. [1]: Rahix/avr-device#195
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
May 5, 2025
avr-device no longer has a `critical-section-impl` feature. Instead it now has a `critical-section` feature that is enabled by default [1]. As such, we can drop the re-exposed feature here. [1]: Rahix/avr-device#195
Rahix
added a commit
to Rahix/avr-hal
that referenced
this pull request
May 5, 2025
avr-device no longer has a `critical-section-impl` feature. Instead it now has a `critical-section` feature that is enabled by default [1]. As such, we can drop the re-exposed feature here. [1]: Rahix/avr-device#195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new svd2rust code needs
critical-sectionfor implementing thePeripherals::take()function. This means almost all uses ofavr-devicewill need it as well.Rename the
critical-section-implfeature to justcritical-sectionand make it a part of the crate's default features.Cc: @LuigiPiucco @tones111
Ref: #157