Skip to content

Add support for ATTiny 1606 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Add support for ATTiny 1606 #183

merged 2 commits into from
Apr 22, 2025

Conversation

hammerlink
Copy link
Contributor

This adds support for the ATTiny 1606

@Rahix
Copy link
Owner

Rahix commented Apr 16, 2025

Hi, thanks a lot for your contribution! Just a heads-up, I am holding off merging new chips right now until #157 is merged, which quite significantly changes the way the register definitions are generated. I will ping you once this change has landed so you can rebase your changes ontop of it.

@Rahix
Copy link
Owner

Rahix commented Apr 18, 2025

Here's the notification: #157 was merged 🎉 Please rebase your work ontop of the new code-generation. You should be able to make out the new structure in src/devices/mod.rs from the way things look for the existing chips. The Makefile is dropped completely.

@hammerlink
Copy link
Contributor Author

@Rahix Looks like a great improvement! I have rebased it, I indeed needed to change src/devices & remove the Makefile.

@@ -0,0 +1 @@
_svd: ../svd/attiny1606.svd
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is now superfluous due to the build-system changes. If you don't have any other patches to add, please drop the patch/attiny1606.yaml file entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, removed it

@Rahix Rahix merged commit 97e6fe5 into Rahix:main Apr 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants