#487 Implement new sample override #488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@thorehusfeldt can you check the schema again? ^^' |
mpsijm
requested changes
Dec 15, 2025
Collaborator
mpsijm
left a comment
mpsijm
left a comment
There was a problem hiding this comment.
Quick code review, didn't test it yet. The CUE schema looks good on first glance (maybe I'd put "ans" before "ans.statement" for consistency, but that's a nit). Note that the JSON schema should also be updated.
| in_file, ans_file = sample.download | ||
| base_name = outputdir / str(i + 1) | ||
| contents[base_name.with_suffix(".in")] = in_file | ||
| if in_file.stat().st_size > 0: |
Collaborator
There was a problem hiding this comment.
Does it ever happen that we can only download a .ans file? I'd say the .in file is required, but maybe I missed something in the discussion.
Same on line 357.
Collaborator
Author
There was a problem hiding this comment.
a .ans file without a .in file does not really make sense... but having neither might be useful?
Collaborator
Author
|
@mpsijm @thorehusfeldt can you check the schemas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #487.
Try to implement new sample data behaviour