Invalidation #333
Merged
Invalidation #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of ["answer", "input", "output"] or [validate.Class.INPUT, validate.Class.ANSWER, validate.Class.OUTPUT] in favour of just passing the class itself, i.e., [validate.InputValidator, validate.OutputValidator, validate.AnswerValidator]. Makes some code more type-safe, and class constructor dispatch becomes trivial.
sanity_check operates on a file, and figures out the desired mode from the file suffix (.in, .ans, .out). Whitespace strictness is an explicit parameter (rather than inferred from validation mode.)
Reduce parameters to one. Reduce return types from four (!) to "only" three
thorehusfeldt
force-pushed
the
feat/invalidation
branch
from
ffd9eac to
dd269c8
Compare
thorehusfeldt
force-pushed
the
feat/invalidation
branch
from
14cb500 to
987cdd5
Compare
thorehusfeldt
force-pushed
the
feat/invalidation
branch
from
a870130 to
66bc6ea
Compare
thorehusfeldt
force-pushed
the
feat/invalidation
branch
from
66bc6ea to
490b8e1
Compare
RagnarGrootKoerkamp
force-pushed
the
feat/invalidation
branch
3 times, most recently
from
c45e8f3 to
4007322
Compare
RagnarGrootKoerkamp
force-pushed
the
feat/invalidation
branch
from
4007322 to
7a3dc1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch aims to establish expected invalidation of test data, in particular, handling purposefully invalid test cases in
invalid_input,invalid_answerandinvalid_output.