Conversation
- cleanup duplicate code path when obtaining app id
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades unity-xcode-builder to v1.3.0 by adding new input options (including test groups, archive type, and submit-for-review) and renaming existing ones for manual signing. It also fixes the notarization workflow, extends test detail upload polling, and improves credential import and cleanup.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Improved Xcode version handling and installer selection logic |
| src/XcodeProject.ts | Updated bundleVersion type and added new properties (e.g. isSteamBuild) |
| src/AppleCredential.ts | Renamed and updated credential inputs for manual signing |
| src/AppStoreConnectClient.ts | Adjusted API client functions and polling logic for build handling |
| package.json | Bumped version and updated some dependency versions |
| action.yml | Updated input details and deprecation messages |
| .github/workflows/validate.yml | Adjusted shell and permissions settings |
| .github/workflows/update-release-tags.yml | Minor syntax adjustments |
| README.md | Documentation updates to reflect renamed and new inputs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-groups: One or more test groups to automatically add to the build when uploading to TestFlight. When using multiple groups, separate them with commas.archive-type: The archive type to use when exporting macOS applications when not uploading to the App Store. Can be one ofapporpkg.submit-for-review: Automatically submit beta build for review and notify testersdeveloper-id-application-certificate: TheDeveloper ID Applicationcertificate encoded as base64 string. Used for signing macOS app bundles when not uploading to app store.developer-id-application-certificate-password: The password for theDeveloper ID Applicationcertificate.developer-id-installer-certificate: TheDeveloper ID Installercertificate encoded as base64 string. Used for signing installer packages for macOS applications.developer-id-installer-certificate-password: The password for theDeveloper ID Installercertificate.certificate->manual-signing-certificatecertificate-password->manual-certificate-passwordsigning-identity->manual-signing-identity