com.openai.unity 8.6.6 #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix mp3 and wav playback from SpeechRequests
This was
linked to
issues
Apr 27, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two main issues: fixing mp3 and wav playback for SpeechRequests and adding new SemanticVAD options for realtime sessions. Key changes include updating the realtime test to use the new DisabledVAD, refactoring VoiceActivityDetectionSettings into an interface with multiple implementations (DisabledVAD, SemanticVAD, ServerVAD), and adjusting JSON conversion and SessionConfiguration to work with the new types.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/TestFixture_13_Realtime.cs | Updated test to instantiate new DisabledVAD |
| Runtime/Realtime/VoiceActivityDetectionSettings.cs | Refactored settings into an interface and added new VAD classes |
| Runtime/Realtime/TurnDetectionType.cs | Added new enum member for Semantic_VAD |
| Runtime/Realtime/SessionConfiguration.cs | Changed parameter type and default instantiation to ServerVAD |
| Runtime/OpenAIClient.cs | Minor update in JSON converter initialization |
| Runtime/Extensions/VoiceActivityDetectionSettingsConverter.cs | Updated converter to handle new IVoiceActivityDetectionSettings types |
| Runtime/Audio/SpeechClip.cs | New SpeechClip constructor for AudioClip integration |
| Runtime/Audio/AudioEndpoint.cs | Adjustments for PCM handling and improved audio response routing |
Files not reviewed (1)
- OpenAI/Packages/com.openai.unity/package.json: Language not supported
OpenAI/Packages/com.openai.unity/Runtime/Extensions/VoiceActivityDetectionSettingsConverter.cs
Outdated
Show resolved
Hide resolved
…ityDetectionSettingsConverter.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 27, 2025
- fix mp3 and wav playback from SpeechRequests - added SemanticVAD options to realtime - added new audio models to static model list --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.