Factor out baseline calculation code from textreporter, for use in pretty and chart #98
Conversation
RafaelGSS
left a comment
There was a problem hiding this comment.
I liked the change on chart.js, but it seems the text.js is breaking. See full diff comparison on: https://gist.github.com/RafaelGSS/9b2e7d8d48d0a866a2cc283667ff9322
- text reporter shouldn't have a
\nbetween each one of them. - It seems you created the baseline analyzer, but you aren't using it on
prettyreporter
Could you provide the screenshot when you change something? Otherwise it takes some time for me to checkout your PR, test the changes, and compare the result with main.
2628b84 to
9c33c1b
Compare
|
I wonder what the difference in settings is between prom-client and bench-node, because Webstorm lights up with every formatting issue with the former and I'm getting no warnings locally from the latter. |
for addition to the other formatters.
Feature parity for textReporter, but chartReporter doesn't work this way.
f2146e6 to
b42f3b7
Compare
|
Finally got past the linter. Woof. |
|
@jdmarshall, would you mind providing the graphic difference between the main and this PR? I mean, what changes in the screen (for pretty, text, and chart report)? This would help people when looking at the CHANGELOG and ending up on this PR. |
|
In the PR or in the commit message? |
I like your chart reports but humans can sometimes struggle a bit even with bar charts. So I wanted to append the faster/slower logic from textReporter.
Then I noticed some redundancy with pretty, and ended up here.
Before:
After: