Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 3.5.0 #970

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Update to 3.5.0 #970

merged 1 commit into from
Sep 11, 2023

Conversation

mnaoumov
Copy link
Collaborator

No description provided.

@mnaoumov mnaoumov self-assigned this Sep 10, 2023
@mnaoumov
Copy link
Collaborator Author

@RafaelGB the permissions you gave me don't allow me to push to master directly. It says I have to go via Pull Request process and with code review and it seems you are the only reviewer who can approve

@RafaelGB RafaelGB changed the title Update to 3.5.0 Update to 3.4.1 Sep 11, 2023
@mnaoumov
Copy link
Collaborator Author

@RafaelGB I think while my fix is super simple, it fixes a quite serious bug, actually a showstopper for me, that's why I decided to fix it.

According to Semver spec #7

Minor version Y (x.Y.z | x > 0) MUST be incremented if new, backward compatible functionality is introduced to the public API. It MUST be incremented if any public API functionality is marked as deprecated. It MAY be incremented if substantial new functionality or improvements are introduced within the private code. It MAY include patch level changes. Patch version MUST be reset to 0 when minor version is incremented.

Long story short, I believe it is 3.5.0 but if you insist, I can change to 3.4.1

@RafaelGB
Copy link
Owner

the releases yaml was updated to use the tag

@RafaelGB
Copy link
Owner

Sure, we can maintain the 3.5.0
The criterion I was following was to raise the Z in case of only fixing bugs in a version

@RafaelGB RafaelGB changed the title Update to 3.4.1 Update to 3.5.0 Sep 11, 2023
@mnaoumov mnaoumov merged commit 9ed8427 into master Sep 11, 2023
3 checks passed
@RafaelGB
Copy link
Owner

@RafaelGB
Copy link
Owner

Once I published https://github.com/RafaelGB/Obsidian-ZettlelFlow maybe I can develop some things here. Again, thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants